Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot join server which has no playername #9243

Closed
TrueBrain opened this issue May 11, 2021 · 0 comments · Fixed by #9245
Closed

Cannot join server which has no playername #9243

TrueBrain opened this issue May 11, 2021 · 0 comments · Fixed by #9245

Comments

@TrueBrain
Copy link
Member

Version of OpenTTD

9e7e87c

Expected result

Be able to join a server no matter what his name is.

Actual result

Client is silently disconnected because of malformed packet.

Steps to reproduce

  • Start a dedicated server with -x -c empty.cfg (assuming empty.cfg doesn't exist).
  • Try to join this server; you won't be able to :P

The problem is that clients reject client-info packets where the client-name is invalid. A dedicated server with no config has an invalid name (it is empty). A regression from an earlier change.

rubidium42 added a commit to rubidium42/OpenTTD that referenced this issue May 11, 2021
…ent and server name

Also warn when the client or server name has not been set and provide pointers on how to set them
rubidium42 added a commit that referenced this issue May 11, 2021
… server name

Also warn when the client or server name has not been set and provide pointers on how to set them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant