Fix: [Network] don't mark the last-joined server as manual #9239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
When joining a game, it is marked as last-joined. Next time you open the Multiplayer GUI, it was marked as "manually added". That means that slowly your list gets more and more "manually" added servers. Which is rather annoying.
I consider "manually" added only the ones you did via "add server". Last-joined should just be that, the one you joined last. If I join another server later, the server before should be forgotten about.
This is a personal opinion one could disagree with. But if we want this old behaviour, we really should not call it "manually", but "history" or something, possibly even with a date of the last join. But I digress, and not something for this PR.
Description
Make last-joined no longer marked as "manually".
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.