Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Network] don't mark the last-joined server as manual #9239

Merged
merged 1 commit into from May 11, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

When joining a game, it is marked as last-joined. Next time you open the Multiplayer GUI, it was marked as "manually added". That means that slowly your list gets more and more "manually" added servers. Which is rather annoying.

I consider "manually" added only the ones you did via "add server". Last-joined should just be that, the one you joined last. If I join another server later, the server before should be forgotten about.

This is a personal opinion one could disagree with. But if we want this old behaviour, we really should not call it "manually", but "history" or something, possibly even with a date of the last join. But I digress, and not something for this PR.

Description

Make last-joined no longer marked as "manually".

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit 9841ebb into OpenTTD:master May 11, 2021
@TrueBrain TrueBrain deleted the network-last-joined branch May 11, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants