Codechange: [Network] split CloseSocket and CloseConnection more clearly #9261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
During work on the Network code I kept hitting a problem: I got totally confused with
Close
vsCloseConnection
.Turns out: its not me!
Depending on the file you look at, it has a different meaning.
Yippie!
Lets add some sanity to the code, shall we?
Description
There should be no functional difference with this PR.
Simple new rules:
As added bonus, the dtors are a lot easier to understand now too.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.