Fix: [OpenGL] Increase timeout when waiting for the GPU to be done with the drawing buffer. #9282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the drawing buffer. The old timeout could be too short if v-sync was on on lower refresh rates.
TrueBrain
reviewed
May 19, 2021
| @@ -1174,7 +1174,7 @@ uint8 *OpenGLBackend::GetAnimBuffer() | |||
| if (this->anim_pbo == 0) return nullptr; | |||
|
|
|||
| #ifndef NO_GL_BUFFER_SYNC | |||
| if (this->sync_anim_mapping != nullptr) _glClientWaitSync(this->sync_anim_mapping, GL_SYNC_FLUSH_COMMANDS_BIT, 10000000); | |||
| if (this->sync_anim_mapping != nullptr) _glClientWaitSync(this->sync_anim_mapping, GL_SYNC_FLUSH_COMMANDS_BIT, 100000000); // 100ms timeout. | |||
There was a problem hiding this comment.
Maybe 100 * 1000 * 1000 to make us count less zeros? Feel free to say no :)
There was a problem hiding this comment.
Hey, I did add a comment 😀
PeterN
approved these changes
May 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Screen refresh could glitch if v-sync was enabled with lower refresh rates.
Description
Increase the buffer sync timeout to make sure we definitely wait longer than the screen refresh.
Limitations
If the GPU is extremely busy, the new timeout will make stutter more likely but graphical glitches a lot less likely.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.