Fixes for window handling changes from f6d5c01 #9270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9269
Motivation / Problem
Since f6d5c01, windows' deletion is immediate.
Dropdowns and Pickers are abusing WC_INVALID class to hide themselves (triggering the assert in #9269).
ProcessScheduledInvalidations()
can do invalid reads if window is self deleted duringOnInvalidateData()
Description
Hide Dropdowns and Pickers by removing them from the opened windows list.
ModifyOnInvalidateData()
to returntrue
if the window is self deleted, and check the return value to prevent invalid reads.Limitations
Probably need to do the same forInvalidateData()
as it callsOnInvalidateData()
.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.