Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Replace TILE_AREA_LOOP with range-based for loops #9254

Merged
merged 1 commit into from May 12, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented May 12, 2021

Motivation / Problem

TILE_AREA_LOOP() is using already implemented iterator. It can easily be replaced with range-based for loop.

Description

Implemented missing begin() and end() in OrthogonalTileArea, and dereference operator in TileIterator.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 merged commit 38c97e1 into OpenTTD:master May 12, 2021
@glx22 glx22 deleted the tile_area branch May 12, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants