Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [Actions] use newly created Actions instead of custom shell-scripting #9284

Merged
merged 1 commit into from May 20, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented May 20, 2021

Motivation / Problem

Between different repositories of OpenTTD we copy/pasted a lot of custom shell-script. This was difficult to maintain, and updating everything is a chore.

Description

Today I introduced three new GitHub Actions:

  • OpenTTD/actions/annotation-check
  • OpenTTD/actions/checkout-pull-request
  • OpenTTD/OpenTTD-git-hooks

Together they remove most of the custom shell scripting we have in GitHub workflows.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit 3477405 into OpenTTD:master May 20, 2021
@TrueBrain TrueBrain deleted the action-cleanup branch May 20, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants