Fix #9202: Invalid test for unset NewGRF override mapping. #9226

PeterN · 2021-05-09T15:48:10Z

Motivation / Problem

#9202 introduced and used an incorrect test for whether an override has been set.

Test for grfid and entity_id being non-zero instead.

May be better to revert and not care, savegames are compressed anyway.

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

The bug fix is important enough to be backported? (label: 'backport requested')
This PR affects the save game format? (label 'savegame upgrade')
This PR affects the GS/AI API? (label 'needs review: Script API')
- ai_changelog.hpp, gs_changelog.hpp need updating.
- The compatibility wrappers (compat_*.nut) need updating.
This PR affects the NewGRF API? (label 'needs review: NewGRF')
- newgrf_debug_data.h may need updating.
- PR must be added to API tracker

TrueBrain · 2021-05-11T16:51:55Z

Why is this PR in draft? Any update? Asking for a friend :)

Fix OpenTTD#9202: Invalid test for unset NewGRF override mapping.

1e98e25

glx22 marked this pull request as draft May 9, 2021 15:49

frosch123 approved these changes May 11, 2021

View reviewed changes

PeterN marked this pull request as ready for review May 11, 2021 18:01

TrueBrain merged commit 3d9436b into OpenTTD:master May 12, 2021

PeterN deleted the redo-9202 branch May 12, 2021 21:16