Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [Network] mark server as offline when no longer reachable #9244

Merged
merged 1 commit into from May 11, 2021
Merged

Fix: [Network] mark server as offline when no longer reachable #9244

merged 1 commit into from May 11, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

When refreshing a server, it showed online if it was offline. That is just weird.

Description

Hook into the OnFailure callback, and mark the server as offline.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit d0eb3e4 into OpenTTD:master May 11, 2021
@TrueBrain TrueBrain deleted the fix-offline-server branch May 11, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubidium42 rubidium42 rubidium42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @rubidium42