Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Use gender-neutral pronouns #9228

Merged
merged 1 commit into from May 15, 2021

Conversation

rubidium42
Copy link
Contributor

Motivation / Problem

See #9203; that PR was incomplete.

Description

grep -Rn '([^C]him' src | grep -v src/lang
grep -Rn '[^Ttm]his[^t]' src | grep -v src/lang
grep -Rn '[^Ttgcs]her[^ie]' src | grep -v src/lang
grep -Rn 'boy' src | grep -v src/lang
grep -Rn '[^iaeou]she' src | grep -v src/lang
grep -Rn '[^sTtwWS_cC>p]he[^srlaixuc]' src | grep -v src/lang
And then some further manual filtering.

Limitations

COPYING.md is kept untouched. Similarly pronouns referring to actual persons have been left alone as well, e.g. Josef Drexler - For his great work on TTDPatch.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

changelog.txt Outdated Show resolved Hide resolved
@James103
Copy link
Contributor

James103 commented May 9, 2021

Have you ran the command grep -Rn 'girl' src | grep -v src/lang as well (in addition to the similar command for "boy")?

@rubidium42
Copy link
Contributor Author

Have you ran the command grep -Rn 'girl' src | grep -v src/lang as well (in addition to the similar command for "boy")?

Yeah, I did that earlier and knew that they were not mentioned in the code at all.

@PeterN
Copy link
Member

PeterN commented May 9, 2021

Not sure it makes sense to alter past changelog entries.

@rubidium42 rubidium42 merged commit 44ca7d9 into OpenTTD:master May 15, 2021
@rubidium42 rubidium42 deleted the incomplete-9203 branch May 15, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants