Fix f6d5c01: Delay deletion when closing windows #9274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Since f6d5c01, windows' deletion is immediate.
ProcessScheduledInvalidations() can do invalid reads if window is self deleted during OnInvalidateData().
And probably other invalid accesses are yet to be found.
Description
Replace
delete this
used inWindow
event handlers, withthis->Close()
which hides the window, but delay the real deletion so it happens in a safe place.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.