Codechange: [Network] Use std::string for admin name and version #9273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Partial conversion of C-string to std::string is not done.
Description
Change
NetworkAdminSocketHandler::admin_name
andNetworkAdminSocketHandler::admin_version
to std::string, and change the parameters of many admin related functions to either std::string or std::string_view depending on the situation.Limitations
None
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.