Codechange: [Network] Use std::string for admin name and version #9273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
May 16, 2021
rubidium42
force-pushed
the
string_network_admin
branch
from
6578689
to
adba7e1
Compare
…ndoing that) in the middle of a C-string
rubidium42
force-pushed
the
string_network_admin
branch
from
adba7e1
to
6209733
Compare
TrueBrain
reviewed
May 29, 2021
rubidium42
force-pushed
the
string_network_admin
branch
from
6209733
to
db80eb7
Compare
rubidium42
force-pushed
the
string_network_admin
branch
from
db80eb7
to
9811038
Compare
TrueBrain
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Partial conversion of C-string to std::string is not done.
Description
Change
NetworkAdminSocketHandler::admin_nameandNetworkAdminSocketHandler::admin_versionto std::string, and change the parameters of many admin related functions to either std::string or std::string_view depending on the situation.Limitations
None
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.