Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: e2e6a4651a73
Choose a base ref
...
head repository: NixOS/nix
compare: e5ed74ec1e19
Choose a head ref
  • 6 commits
  • 10 files changed
  • 1 contributor

Commits on May 19, 2021

  1. Add a dependencies field to DrvOutputInfo 

    Currently never used, nor set but will be useful shortly
    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    5f527f3 View commit details
    Browse the repository at this point in the history

  2. Store the realisation deps on the local store

    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    3f22d9c View commit details
    Browse the repository at this point in the history

  3. Extract a generic computeClosure function 

    Move the `closure` logic of `computeFSClosure` to its own (templated)
function.
That way we can reuse it for the realisations too
    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    ec5e04c View commit details
    Browse the repository at this point in the history

  4. Add a method to compute the closure of a realisation 

    Only considers the closure in term of `Realisation`, ignores all the
opaque inputs.

Dunno whether that’s the nicest solution, need to think it through a bit
    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    f7fcde3 View commit details
    Browse the repository at this point in the history

  5. Properly track the drvoutput references when building

    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    ed84a5d View commit details
    Browse the repository at this point in the history

  6. Make copyPaths copy the whole realisations closure 

    Otherwise registering the realisations on the remote side might fail as
it now expects a complete closure
    @thufschmitt
    thufschmitt committed May 19, 2021
    Copy the full SHA
    e5ed74e View commit details
    Browse the repository at this point in the history