Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: af7ffe882f2e^
Choose a base ref
...
head repository: NixOS/nix
compare: e2e6a4651a73
Choose a head ref
  • 8 commits
  • 13 files changed
  • 1 contributor

Commits on May 17, 2021

  1. Always send the realisations as JSON

    Align all the worker protocol with `buildDerivation` which inlines the
    realisations as one opaque json blob.
    That way we don’t have to bother changing the remote store protocol
    when the definition of `Realisation` changes, as long as we keep the
    json backwards-compatible
    thufschmitt committed May 17, 2021
    Copy the full SHA
    af7ffe8 View commit details
    Browse the repository at this point in the history
  2. Add a dependencies field to DrvOutputInfo

    Currently never used, nor set but will be useful shortly
    thufschmitt committed May 17, 2021
    Copy the full SHA
    ce41fce View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    0c1d9d4 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Extract a generic computeClosure function

    Move the `closure` logic of `computeFSClosure` to its own (templated)
    function.
    That way we can reuse it for the realisations too
    thufschmitt committed May 19, 2021
    Copy the full SHA
    af83ce9 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    51704fe View commit details
    Browse the repository at this point in the history
  3. Add a method to compute the closure of a realisation

    Only considers the closure in term of `Realisation`, ignores all the
    opaque inputs.
    
    Dunno whether that’s the nicest solution, need to think it through a bit
    thufschmitt committed May 19, 2021
    Copy the full SHA
    9ebdcc4 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    e6b6982 View commit details
    Browse the repository at this point in the history
  5. Make copyPaths copy the whole realisations closure

    Otherwise registering the realisations on the remote side might fail as
    it now expects a complete closure
    thufschmitt committed May 19, 2021
    Copy the full SHA
    e2e6a46 View commit details
    Browse the repository at this point in the history