Change: reworked the debug levels for network facility #9251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Running a dedicated server shows a lot of information that is not all that relevant.
Also, during working on the STUN patch, I noticed that often I saw too much debugging, or not enough.
After reading #9171 I came to realisation we have been trying to do "our own thing" instead of looking to the world. That gave me inspiration to just use the default: fatal / error / warning / info / debug / trace setup. This PR implements that.
Description
I also applied some consistency to all strings:
: %s
for error instead of all the combinations we had (with error
,failed with
, ...).[udp]
which don't really mean anything.Also:
desync
facility, as it had little to do withnet
.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
Complete list of debug messages on net facility
In case you find it easier to read the full list of messages we now have, here you go, sorted by level: