update MSYS2 build/install guidelines #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2021
|
Why did you remove the line pointing to lib/scopeprotocols/kernels? That will make OpenCL builds fail to initialize. |
On the one hand, the directory does not exist when I build scopehal-apps. On the other hand, it is not copied in the CI workflow: https://github.com/azonenberg/scopehal-apps/blob/master/.github/workflows/build.yml#L172-L184. Therefore, I thought the documentation was outdated. Anyway, I removed that change from this PR. We can discuss it afterwards. |
|
The CI workflow builds on a VM without a GPU, so none of the OpenCL stuff can be tested there. It's probably not enabled at compile time because there's no point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented on Twitter (https://twitter.com/azonenberg/status/1393261244598026241):