Codechange: [Network] Use C++ string functions to generate company password hash #9276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Mixing C and C++ string functionality.
Description
Replace the C-strings with stringstreams, and seprintf with
<<
on the stringstream.Limitations
None. Character-for-character compatible output.
Having said that, it's a quite archaic way of doing things. We should think about adding flags to the passwords for different hash/salting methods, so when we get proper cryptographic logic those can quite easily be used as well. But... that is way out of scope for this.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.