Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Network] Use C++ string functions to generate company password hash #9276

Merged
merged 1 commit into from May 17, 2021

Conversation

rubidium42
Copy link
Contributor

Motivation / Problem

Mixing C and C++ string functionality.

Description

Replace the C-strings with stringstreams, and seprintf with << on the stringstream.

Limitations

None. Character-for-character compatible output.

Having said that, it's a quite archaic way of doing things. We should think about adding flags to the passwords for different hash/salting methods, so when we get proper cryptographic logic those can quite easily be used as well. But... that is way out of scope for this.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 merged commit e2dc5aa into OpenTTD:master May 17, 2021
@rubidium42 rubidium42 deleted the string_password_hash branch May 17, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants