New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MinGW] Fix MinGW32 build failure and almost all MinGW32/MinGW64 warnings #9268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got no clue about the DLL code, though it does not look obviously wrong.
The last commit smells a bit as I wouldn't expect the function parameters to be that different.
Regarding the last warning, might there be something wrong with the definition of LOGFONT so that is really big with MinGW?
Motivation / Problem
MinGW32 fails to build OpenTTD, and many warnings are generated by MinGW32 and MinGW64.
Description
First commit solves
Second commit is just a cleanup (less
LoadLibraryList()
calls)Next 3 commits are MinGW32 specific.
Third commit solves
Fourth commit solves
Fifth commit solves
Following commits are for MinGW32 and MinGW64
Sixth commit solves
Seventh commit solves
Eighth commit solves
Ninth commit solves
And last commit solves a build failure introduced recently.
Limitations
There's a remaining warning for MinGW32 release build, displayed at link time
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.