Fix #9255: [Network] TCPConnecter crashes when hostname not found #9259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9255
Motivation / Problem
#9255 reports two problems:
Resolve()
which can callOnFailure
which is not yet loaded at that point in time.Resolve
can callOnFailure
while the game-state is not locked.Description
By solving the second the first automagically solves itself, but I think it is a pitfall the next person will in before you know it. As such, I also addressed the first one. Call it overkill.
Basically:
OnFailure
inResolve
is delayed till the game-state is locked (inCheckActivity
, which guarantees this).Resolve
is called fromCheckActivity
and no longer in the ctor.I could combine both nicely in a single enum, which also helps understanding a bit more what the step are that are taken by the resolvement.
The status is not updated to failure/success in
CheckActivity
itself, as both result in areturn true
which will destroy the object seconds later. In other words, nobody will be able to read this updated status anyway.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.