Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Actions] Annotations not shown for MSVC #9247

Merged
merged 1 commit into from May 11, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented May 11, 2021

Motivation / Problem

When parsing compiler output for MSVC builds, GitHub fails to find the file in message to real file in repo.
And the resulting annotations are not shown in the diff view.

Description

Tell MSVC to use full path in diagnostics output.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label May 11, 2021
@glx22 glx22 merged commit c0a0d85 into OpenTTD:master May 11, 2021
@glx22 glx22 deleted the annotations branch May 11, 2021 19:43
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants