Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The flight plan should not be silently truncated in target LVLH when the prediction of the target is too short #2982

Open
eggrobin opened this issue May 11, 2021 · 0 comments
Labels

Comments

@eggrobin
Copy link
Member

@fat-lobyte came across this issue.
In the image below, the manœuvre is not displayed, but there is no error message. The issue may be worked around by increasing the tolerance or number of prediction steps, but nothing suggests that.
Freshness of the prediction of the target is not critical (it is passive except in exotic cases at close range), so there should be no harm in automatically increasing the number of steps requested for that prediction when it is insufficient for the flight plan.
Note that this partially decouples it from the current prediction parameters, which is what is currently used:

// If there is a target vessel, it is integrated with the same parameters as
// the given (current) vessel. This makes it possible to plot the prediction
// of the current vessel.
if (renderer_->HasTargetVessel()) {
renderer_->GetTargetVessel().set_prediction_adaptive_step_parameters(
prediction_adaptive_step_parameters);
}

We may want to make this temporary, instead of mutating the prediction parameters of the target.

@eggrobin eggrobin added the bug label Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant