Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9256, 12e43c697d2: invalid read after free. #9258

Merged
merged 1 commit into from May 12, 2021

Conversation

frosch123
Copy link
Member

Collateral change: ScriptEventVehicleAutoReplaced is now only called when the head engine changes, so only when the VehicleID of the consist changes.

Motivation / Problem

#9256
While spawning an AI event, owner and Index of a vehicle are accessed after the vehicle has already been sold.

Description

The event is now spawned before the vehicle is sold. (but when success is already known)

This PR also changes whether the event is spawned when replacing wagons:

  • The AIEvent contains the old and new vehicle Id of the consist head.
  • When only auto-replacing wagons, the head does not change, so the event would say oldid==newid.
  • No idea whether an event is intented/useful here.

Limitations

Original intent of event when replacing wagons is unknown.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Collateral change: ScriptEventVehicleAutoReplaced is now only called when the head engine changes, so only when the VehicleID of the consist changes.
@frosch123 frosch123 merged commit 5bd8144 into OpenTTD:master May 12, 2021
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label May 13, 2021
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants