Fix #9256, 12e43c697d2: invalid read after free. #9258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collateral change: ScriptEventVehicleAutoReplaced is now only called when the head engine changes, so only when the VehicleID of the consist changes.
Motivation / Problem
#9256
While spawning an AI event, owner and Index of a vehicle are accessed after the vehicle has already been sold.
Description
The event is now spawned before the vehicle is sold. (but when success is already known)
This PR also changes whether the event is spawned when replacing wagons:
Limitations
Original intent of event when replacing wagons is unknown.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.