Codechange: use std::string in network chat #9266
Merged
+61
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
previously approved these changes
May 14, 2021
rubidium42
force-pushed
the
string_network_chat
branch
from
ba91273 to
795ce40
Compare
LordAro
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Partial conversion of C-string to std::string is not done.
Description
Convert NetworkTextMessage and Network*SendChat to use std::string, as well as add a GetString that returns a std::string.
Limitations
nullptrcannot be used to for parameters that are "not useful" for that set of other parameters.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.