Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve autoreplace strings #9292

Merged
merged 2 commits into from May 23, 2021
Merged

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented May 23, 2021

Motivation / Problem

Group autoreplace protection doesn't apply to sub-groups by default, but a hidden Ctrl feature exists for that.
Wagon removal may affect group only, or ungrouped vehicles, depending on context, and it's not very visible. There's also a hidden Ctrl feature when groups are concerned.

Description

Hints about Ctrl in tooltips where needed, and show when ungrouped or group are affected by "wagon removal" toggle.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 merged commit 7c0762d into OpenTTD:master May 23, 2021
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label May 23, 2021
@glx22
Copy link
Contributor Author

glx22 commented May 23, 2021

Only first commit is backportable.

@glx22 glx22 deleted the improve_autoreplace_strings branch May 23, 2021 19:53
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants