Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoreplace protection doesn't apply to sub-groups #9287

Closed
Ben79487 opened this issue May 21, 2021 · 3 comments
Closed

Autoreplace protection doesn't apply to sub-groups #9287

Ben79487 opened this issue May 21, 2021 · 3 comments

Comments

@Ben79487
Copy link

Version of OpenTTD

I am using Linux (Ubuntu 20.10) and am using OpenTTD 1.10.3.

Expected result

Autoreplace protection (in the vehicles list) protects a group as well as all of its sub-groups.

Actual result

While it protects the vehicles in the immediate group, it does not protect its sub-groups.

For example, if I have group B in group A, and I start autoreplacing and protect group A, vehicles in group B will still get autoreplaced.

Steps to reproduce

  1. Unzip and load the savegame attached.
  2. Check the road vehicles window. Notice that I have set all MPS Regal Buses to be replaced by Foster Buses. Also look at the two groups, "Gufingfield" and "Betbourne". "Gufingfield" has been split into two groups, "Crosstown" and "East", with MPS Regal Buses within, while "Betbourne" only has a lone MPS Regal Bus. Both "Gufingfield" and "Betbourne" have been protected from autoreplacement.
  3. Send all vehicles for maintenance to speed up autoreplace, and watch as the buses in the group "Gufingfield" get autoreplaced into Foster Buses, while the lone vehicle in "Betbourne" remains a MPS Regal Bus.

Further thoughts

While this could be considered proper behavior, if it is, it would be unintuitive, as one would expect making changes to a group would also make changes to its descendants, like setting the color livery, which also sets the defaults for the sub-groups.

Autoreplace cancel failure.zip

@glx22
Copy link
Contributor

glx22 commented May 22, 2021

Propagation to sub-groups depends on Ctrl being pressed or not.

@glx22
Copy link
Contributor

glx22 commented May 22, 2021

Same applies to wagon removal in nightlies. We should probably update tooltips.

@Ben79487
Copy link
Author

Tooltips updated with PR 9292. Closing this issue, as it seems to be fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants