Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several GitHub workflow related fixes #52

Merged
merged 4 commits into from May 24, 2021

Conversation

TrueBrain
Copy link
Member

No description provided.

@TrueBrain TrueBrain added the changelog: hide This Pull Request should not be mentioned in the changelog label May 24, 2021
repository: OpenTTD/OpenTTD-git-hooks
path: git-hooks
ref: master
uses: OpenTTD/actions/checkout-pull-request@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use @main ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that means if we make any changes in OpenTTD/actions, it is live for all repositories that use it. This can be very annoying, as that means master/main always has to work, and never leaves any room to experiment.

As such, it is common with GitHub Actions that you tag a version that is stable, and use that when using the action. This means you can develop on master/main, and not screw over every project using your action while doing :D

We already use @v2 in the other workflow files btw :)

@TrueBrain TrueBrain merged commit beffd33 into OpenTTD:master May 24, 2021
@TrueBrain TrueBrain deleted the github-workflow branch May 24, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: hide This Pull Request should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants