Fix #9264: Do not attach temporary wagons to free wagon chains when autoreplacing #9278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Various failure conditions due to free-wagon chains exceeding the train length limit during autoreplace operations, see: #9264.
Description
Wagons created or moved during an autoreplace operation should always either be sold or attached to a replacement vehicle before the operation has completed.
Therefore it isn't necessary for them to be attached to an existing free wagon chain, (temporarily or otherwise).
This avoids the various failure paths associated with exceeded free wagon chain length limits.
Limitations
N/A
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.