Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this repository a Javascript Action #10

Closed
wants to merge 2 commits into from

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Oct 18, 2019

The branch used for this PR is based on my js-action branch, tested on this PR.

I dropped the test workflow as it probably needs changes inside the hooks.
I also updated urls in package.json, but I think this package will never be on npm registry .

As the test PR shows there, the files in node_modules don't pass the commit check, but it may not be a good idea to touch files placed here by npm install.

@TrueBrain
Copy link
Member

Sorry, I did not see this PR existed. With #16 I went with a slightly alternative route, and use the (new) composite action. I also tried the Dockerfile approach, but that wasn't much cleaner.

Please let me know what approach you like more.

@glx22
Copy link
Contributor Author

glx22 commented May 20, 2021

This PR is from before composite actions were possible. I think #16 is better.

@TrueBrain TrueBrain closed this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants