Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a thread to recompute the past of an Ephemeris #2937

Merged
merged 15 commits into from
Apr 4, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Apr 3, 2021

At this point that thread is mostly harmless. This PR contains code refactoring that will lay the groundwork for future developments.

Part of #2400, take two.

And it's Easter, have an 🥚.

@@ -1354,6 +1354,14 @@ @inbook{IserlesNørsettOlver2006
title = {Highly Oscillatory Quadrature: The Story so Far},
}

@incollection{Lovecraft1922,
Copy link
Member

@eggrobin eggrobin Apr 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The collection is a periodical, so @article. If we believe Wikipedia’s

Home Brew Vol. 1 #1–6

this would be

@article{Lovecraft1922,
  journaltitle = {Home Brew},
  volume = {1},
  number = {1--6},
  date = {1992-02/1992-07},
  &c.
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should have been 1922…

Sorry, something went wrong.

@pleroy
Copy link
Member Author

pleroy commented Apr 4, 2021

retest this please

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Apr 4, 2021
@pleroy pleroy merged commit ca98b4b into mockingbirdnest:master Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants