Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #612

Merged
merged 5 commits into from May 18, 2021
Merged

Minor cleanup #612

merged 5 commits into from May 18, 2021

Conversation

rroohhh
Copy link
Contributor

@rroohhh rroohhh commented May 18, 2021

Opened the nmigen codebase with a language server for the first time and saw some unused imports :)

Also found two small bugs while going through the files :)

The commit messages should speak for themselves.

If you want I can also split this into multiple PRs.

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #612 (9729081) into master (d09dedf) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   81.50%   81.46%   -0.05%     
==========================================
  Files          49       49              
  Lines        6461     6446      -15     
  Branches     1287     1287              
==========================================
- Hits         5266     5251      -15     
  Misses       1007     1007              
  Partials      188      188              
Impacted Files Coverage Δ
nmigen/_utils.py 80.45% <ø> (-0.23%) ⬇️
nmigen/hdl/ast.py 89.98% <ø> (-0.04%) ⬇️
nmigen/lib/cdc.py 90.58% <ø> (-0.11%) ⬇️
nmigen/sim/_pyclock.py 100.00% <ø> (ø)
nmigen/sim/_pyrtl.py 95.74% <ø> (-0.07%) ⬇️
nmigen/back/rtlil.py 80.87% <100.00%> (-0.03%) ⬇️
nmigen/hdl/dsl.py 99.73% <100.00%> (-0.01%) ⬇️
nmigen/hdl/ir.py 95.45% <100.00%> (-0.03%) ⬇️
nmigen/hdl/rec.py 93.40% <100.00%> (ø)
nmigen/hdl/xfrm.py 96.24% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09dedf...9729081. Read the comment docs.

@whitequark
Copy link
Member

Please split, NFC cleanup in one PR, bugfixes in others.

@rroohhh rroohhh changed the title Minor cleanup and bugfixes Minor cleanup May 18, 2021
@rroohhh
Copy link
Contributor Author

rroohhh commented May 18, 2021

Ok, split the bugfix off into #613.

@whitequark whitequark merged commit b38b2cd into amaranth-lang:master May 18, 2021
@rroohhh rroohhh deleted the minor_cleanup branch May 18, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants