Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9264: Do not attach temporary wagons to free wagon chains when autoreplacing #9278

Merged
merged 1 commit into from May 23, 2021

Conversation

JGRennison
Copy link
Contributor

Motivation / Problem

Various failure conditions due to free-wagon chains exceeding the train length limit during autoreplace operations, see: #9264.

Description

Wagons created or moved during an autoreplace operation should always either be sold or attached to a replacement vehicle before the operation has completed.
Therefore it isn't necessary for them to be attached to an existing free wagon chain, (temporarily or otherwise).
This avoids the various failure paths associated with exceeded free wagon chain length limits.

Limitations

N/A

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 added the backport requested This PR should be backport to current release (RC / stable) label May 23, 2021
@rubidium42 rubidium42 merged commit a896753 into OpenTTD:master May 23, 2021
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
@JGRennison JGRennison deleted the fix-9264 branch January 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants