Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscreteTrajectorySegmentRange #3140

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 7, 2021

The first bit of #3136.

namespace physics {
namespace internal_discrete_trajectory_segment_range {

// A range of segments in a DiscreteTrajectory, iterator upon using |Iterator|.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn’t DiscreteTrajectory specific—indeed you test it with vector iterators.
Move it to base; eventually we will replace it with std::ranges::subrange.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Oct 7, 2021
@pleroy pleroy merged commit 6422bbe into mockingbirdnest:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants