Replace Big Man Boogie with Keep on Rolling #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orudge
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Tested with OpenTTD 1.0(!) using both Win32/MCI and DirectMusic drivers and the song played fine. Would be nice to be able to keep both tracks but it seems there is a hard-coded limit on the number of tracks - would need some changes to OpenTTD itself to accommodate another track.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12 (hopefully!).
This replaces the track “Big Man Boogie” by Jim Redfarn with Keep on Rolling by Trolley Trev. This track used to be in OpenMSX but was removed because of technical problems with the track.
This is a fixed version of that track, fixed by @DevanWolf.
The fixed track was downloaded from here: https://www.tt-forums.net/viewtopic.php?p=1220629#p1220629
Please test if this PR will work in OpenTTD, especially if you're on Windows. The original bug report said “'Keep on rolling' causes the Windows MCI playback to crash”, so please test that before merging.