Fix: pproxy changed their API without telling anyone #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library doesn't have a changelog, and clearly it saw a need to change the API without letting anyone know.
LordAro
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library doesn't have a changelog, and clearly it saw a need
to change the API without letting anyone know.
Change upstream happened here:
qwj/python-proxy@cb2669b#diff-982910a7706c3ae15c6861fc73095d442f355bb2d154166a7da609c865a9d220L323
Mostly, notice how much it sucks to use commit messages like this? For anyone complaining that we ask people to use real commit messages .. this is why :D