Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basys3: Implement Basys3Platform #147

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

basys3: Implement Basys3Platform #147

wants to merge 3 commits into from

Conversation

chivay
Copy link

@chivay chivay commented Mar 14, 2021 •
edited

Hi,
this patch adds support for Digilent Basys 3.

Tested locally with Blinky.

whitequark
whitequark reviewed Mar 14, 2021
View reviewed changes
nmigen_boards/basys3.py Outdated Show resolved Hide resolved
@chivay chivay requested a review from whitequark March 15, 2021 23:15
whitequark
whitequark reviewed Mar 15, 2021
View reviewed changes
nmigen_boards/basys3.py Outdated
default_clk = "clk100"

_basys_iostandard = "LVCMOS33"
_default_attrs = Attrs(IOSTANDARD=_basys_iostandard)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please inline these. They do not change once correct because the board is fixed, so factoring them out is not useful, and it is easier to read the code where the attributes are present where they are used.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@chivay chivay requested a review from whitequark March 16, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark Awaiting requested review from whitequark

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chivay @whitequark