Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8810: "aircraft out of fuel" news was looking in the wrong place #8832

Merged
merged 1 commit into from Mar 9, 2021
Merged

Fix #8810: "aircraft out of fuel" news was looking in the wrong place #8832

merged 1 commit into from Mar 9, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

This never worked, I guess ...

Description

v->tile for aircrafts is always zero when in the air. Only when
it starts its landing (or take-off) patterns it becomes a sane
value.
So instead, base the news on the last x/y coordinates of the plane.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain
Fix OpenTTD#8810: "aircraft out of fuel" news was looking in the wron…
90a6c06 
…g place

v->tile for aircrafts is always zero when in the air. Only when
it starts its landing (or take-off) patterns it becomes a sane
value.
So instead, base the news on the last x/y coordinates of the plane.
@TrueBrain TrueBrain merged commit 68e92d2 into OpenTTD:master Mar 9, 2021
@TrueBrain TrueBrain deleted the plane-with-no-fuel branch March 9, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @LordAro