Add: GUI option to select video driver. #8816
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Hardware GPU acceleration doesn't always behave as expected and performance results may vary.
Description
As we will never be able to test any possible GPU/driver/OS combination, expose the video driver setting to the GUI.
Limitations
It is not possible to modify driver parameters via the GUI. Also, selecting an entry on the drop-down will silently drop all driver parameters from the config file.
It takes the cheap way and makes the user do the game restart.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
Also use this opportunity to store driver factory strings as std::string.