Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8733: Can't buy train engine when the "Engines only" filter is a… #8849

Merged
merged 1 commit into from Mar 11, 2021
Merged

Fix #8733: Can't buy train engine when the "Engines only" filter is a… #8849

merged 1 commit into from Mar 11, 2021

Conversation

stormcone
Copy link
Contributor

…ctive

Fixes #8848.

Motivation / Problem

Can't buy train engine when the "Engines only" filter is active.

Description

The CargoID passing across the commands in the end have to be smaller than the number of cargoes or be the invalid cargo. So changes the CargoID to CT_INVALID.

OpenTTD/src/vehicle_cmd.cpp

Line 102 in 3cb2dd4

if (cargo >= NUM_CARGO && cargo != CT_INVALID) return CMD_ERROR;

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

nielsmh
nielsmh approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@nielsmh nielsmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@LordAro LordAro merged commit 9c5a7d3 into OpenTTD:master Mar 11, 2021
@stormcone stormcone deleted the patch-2 branch November 8, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsmh nielsmh nielsmh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't buy train engine when the "Engines only" filter is active
3 participants
@stormcone @nielsmh @LordAro