Fix: if bootstrap failed, it could end with an empty screen instead of error #8856
+80
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
reviewed
Mar 13, 2021
TrueBrain
force-pushed
the
bootstrap-failure
branch
from
9ca5b07 to
bae3761
Compare
TrueBrain
changed the title
…f error There are various of ways bootstrap can fail: - Failing network connection - Incomplete download - No write permissions - Disk full - (others I forgot) They all result in a screen with no windows. To ensure we at least always show something when anything bad happens, if the bootstrap is not successful, show a screen what the next step for the human should be.
For example, if you have a config that defines OpenGFX as baseset but for some reason you have no basesets anymore. In that case bootstrap downloads OpenGFX for you, but it will still show the error that "OpenGFX was not found" after the bootstrap. This was an error generated before the bootstrapped kicked in. Simply muting all errors during bootstrap solves this; as we cannot show them anyway, this is fine. Any errors that remain after bootstrap will be generated again anyway.
TrueBrain
force-pushed
the
bootstrap-failure
branch
from
bae3761 to
8032eac
Compare
LordAro
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8855
Motivation / Problem
Bootstrap had a flow where it could leave the screen with no open window. This is rather confusing for any human. Show an error instead, with next steps.
Description
Limitations
This does not show the real error that happened. Some flows do have some snippets of information (like "write to file failed"), but most just close the download window. Additionally, showing real errors is rather difficult without hacking or rewriting the error window. Both felt a bit excessive for something that shouldn't happen in most cases.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.