Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two “technical” strings appear in eints that shouldn't be translatable #61

Closed
Wuzzy2 opened this issue Mar 14, 2021 · 3 comments
Closed

Two “technical” strings appear in eints that shouldn't be translatable #61

Wuzzy2 opened this issue Mar 14, 2021 · 3 comments

Comments

@Wuzzy2
Copy link

Wuzzy2 commented Mar 14, 2021

I noticed in eints that OpenGFX has two strings which IMO should not be translatable at all:

  • STR_GRF_NAME: This is “{TITLE}”
  • STR_OPENTTD_VERSION: This is literally just a version number

I assume these strings are there for technical reasons only, a translation would never be appropriate. Right?

So I think those strings should be removed from eints.
@glx22
Copy link
Contributor

glx22 commented Mar 14, 2021

eints just reads the lang file, can't add or remove strings if they are in the file.

@LordAro
Copy link
Member

LordAro commented Mar 22, 2021

Working as expected. All "technical" strings are like this

@LordAro LordAro closed this as completed Mar 22, 2021
@Wuzzy2
Copy link
Author

Wuzzy2 commented Mar 22, 2021

The reason I opened this because the only reasonable “translation” is a 1:1 copy. I'm worried that confused non-technical translators could put something invalid here and cause breakage.

LordAro added a commit to LordAro/OpenGFX that referenced this issue Mar 23, 2021
@LordAro
Fix OpenTTD#61: Remove unneccessarily translatable string
f06d40b
@LordAro LordAro mentioned this issue Mar 23, 2021
Merged
LordAro added a commit that referenced this issue Mar 23, 2021
@LordAro
Fix #61: Remove unneccessarily translatable string
4e28d0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wuzzy2 @glx22 @LordAro