Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Aircraft ran out of fuel" messages point to tile 0 instead of where the aircraft is. #8810

Closed
James103 opened this issue Mar 6, 2021 · 0 comments
Closed

"Aircraft ran out of fuel" messages point to tile 0 instead of where the aircraft is. #8810

James103 opened this issue Mar 6, 2021 · 0 comments
Milestone
1.11.0

Comments

@James103
Copy link
Contributor

James103 commented Mar 6, 2021

Version of OpenTTD

1.11.0-beta2

Expected result

When a news message "Aircraft ran out of fuel" shows up, it points to where the aircraft is (like it used to do in older versions)

Actual result

When a news message "Aircraft ran out of fuel" shows up, it always points to tile 0.

Steps to reproduce

  1. Build some airports.
  2. Buy an aircraft.
  3. Give the aircraft some orders so it can fly.
  4. Close all airport hanger windows to work around Crash/assertion failure when removing airport when hangar window open #8809.
  5. Demolish the airports.
  6. Wait a few in-game weeks.
  7. The aircraft will crash, and a news message "Aircraft ran out of fuel" will pop up.
  8. Click on the news message. It will scrollto 0 instead of take you to where the aircraft is.
@TrueBrain TrueBrain added this to the 1.11.0 milestone Mar 8, 2021
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Mar 9, 2021
@TrueBrain
Fix OpenTTD#8810: "aircraft out of fuel" news was looking in the wron…
90a6c06 
…g place

v->tile for aircrafts is always zero when in the air. Only when
it starts its landing (or take-off) patterns it becomes a sane
value.
So instead, base the news on the last x/y coordinates of the plane.
@2TallTyler 2TallTyler mentioned this issue Apr 5, 2021
Closed
@James103 James103 mentioned this issue Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
2 participants
@TrueBrain @James103