Add: Option to (dis-)allow accelerated video drivers. #8812
Conversation
michicc
changed the title
|
GitHub, please use the commit title I want. |
|
Just as alternative to this, should we allow selecting which video driver to use? (in a drop-down in Game Options or something). |
|
For at least our release binaries, this will always be two, won't it? We don't build Allegro IIRC and we treat SDL as exclusive to everything else. |
|
Indeed; for those that have compiled more, will see more, but releases will have two. I think that a dropdown makes it a bit more clear what is going on, and also a bit more future-proof. It is very close to what you already did, just a different way of naming it, but that is what I had in my head :D So just mentioning it as an alternative to this. Similar, I would like to allow users to be able to select a different blitter in-game. So these two options go hand-in-hand :) |
|
First of all, does this even work or is my CPU just too good? Second, the GUI sizes seem a bit off... |
The video drivers using the OpenGL backend are currently our only accelerated drivers. The options defaults to off for macOS builds and to on everywhere else.
michicc
force-pushed
the
pr/setting_accel
branch
from
5eb8fce to
a760132
Compare
|
One minor thing with the current implementation of this approach is that if you do not have OpenGL support, the "Accelerated drawing" is still enabled, giving the suggestion it is using OpenGL, but it really isn't. Mostly in games this is then disabled to reflect the current loaded situation, despite you requested another situation. Not sure how to resolve that nicely, in terms of UX. But #8816 has a similar issue. A possible solution could be that if you have "Accelerated drawing" on, and it fails to load a driver with on, you get an error message on startup indicating you don't have accelerated drawing active, and disable the button .. but that would be a bit weird, as that changes your "preference", so if you ever do have a working OpenGL, with that config, it would never try again. Not sure how to go about this. Possibly a second indicator to tell if it is really enabled / disabled. |
|
Initially I wanted to have a text like |
|
I have been looking at this a bit, and with the timeline for 1.11, I think this is the best approach for now. I still would like to replace it with #8816 if we get the chance, but we can do this in 1.12, and make it all pretty etc. In the end, at the moment, it is better to have an option for players to disable a laggy driver, than to make the bikeshed a nice colour. And I think it is unlikely someone with a laggy game shows up with the knowledge to debug it any time soon :D That does leave the question: can we indicate somehow if acceleration is active or not, if you don't have acceleration supported? |
Show the currently active drivers in the Game Options window. |
A bit too hidden for me. So I came up with this:
Text needs tuning, of course :) |
Motivation / Problem
Hardware GPU acceleration doesn't always behave as expected and performance results may vary.
Description
As we will never be able to test any possible GPU/driver/OS combination, allow users the option to allow or disallow an accelerated video driver. The video drivers using the OpenGL backend are currently our only accelerated drivers.
The options defaults to off for macOS builds and to on everywhere else.
Limitations
Default value is open to discussion. GUI could look better. It takes the cheap way and makes the user do the game restart.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.