Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmlc doesn't throw an error when GRF name missing #194

Closed
EmperorJake opened this issue Mar 15, 2021 · 2 comments · Fixed by #200
Closed

nmlc doesn't throw an error when GRF name missing #194

EmperorJake opened this issue Mar 15, 2021 · 2 comments · Fixed by #200

Comments

@EmperorJake
Copy link

When you leave a GRF name out of the command, i.e. "nmlc --grf myfile.nml" the program hangs on "Reading..." instead of throwing an error or giving the GRF a default name. If the command is entered incorrectly it should display an error because I incorrectly assumed it would work the same way as another program and wasted an embarrassing amount of time trying to fix it.
@glx22
Copy link
Contributor

glx22 commented Mar 15, 2021

It's reading from standard input and writing to a grf file named "myfile.nml", as invoked.

@nielsmh
Copy link
Contributor

nielsmh commented Mar 15, 2021

It's reading from standard input and writing to a grf file named "myfile.nml", as invoked.

Suggest then improving the UI by changing the Reading... message into Reading "filename.nml"... or Reading standard input... depending on whether an input filename was given.

@glx22 glx22 mentioned this issue Apr 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change: Display input filename glx22/nml
3 participants
@nielsmh @glx22 @EmperorJake