Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [Actions] update environment variable for AWS region #8827

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Fix: [Actions] update environment variable for AWS region #8827

merged 1 commit into from
Mar 8, 2021
+1 −1

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

AWS prefers we use AWS_DEFAULT_REGION.

Description

It seems both work, but documentation no longer mentions AWS_REGION. So let's be a good boy :)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro
Copy link
Member

LordAro commented Mar 8, 2021

Don't want to rename the secret too?

@TrueBrain
Copy link
Member Author

Nope; that will be a lot of work, for no gain :)

@TrueBrain TrueBrain merged commit 64a8c38 into OpenTTD:master Mar 8, 2021
@TrueBrain TrueBrain deleted the fix-aws-region branch March 8, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @LordAro