Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Scale PIP-padding the same as regular padding. #8829

Merged
merged 1 commit into from Mar 9, 2021
Merged

Fix: Scale PIP-padding the same as regular padding. #8829

merged 1 commit into from Mar 9, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 9, 2021

Motivation / Problem

Padding around UI elements is inconsistent when "Interface size" set to anything other than "Normal". This is easily noticeable on the AI/Game Script Configuration window, where the last button does not line up correctly.

Description

This problem is solved scaling the PIP padding values in the same way that regular padding values are scaled.

Limitations

Disturbs me very sprites. Goes it throw out limitation?

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN
Copy link
Member Author

PeterN commented Mar 9, 2021

Before:
pip-padding-before
After:
pip-padding-after

LordAro
LordAro approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to check for pre-existing workarounds in gui code

@TrueBrain TrueBrain merged commit 9fdc881 into OpenTTD:master Mar 9, 2021
@PeterN PeterN deleted the pip-scaling branch March 9, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterN @LordAro @TrueBrain