Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8825: [OpenGL] Don't clear cursor cache from the game loop thread. #8826

Merged
merged 1 commit into from Mar 8, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Mar 8, 2021

Motivation / Problem

OpenGL functions may no be called from other threads except the main thread, which could happen when clearing the cursor cache.

Description

Queue the pending clear until the next time the main thread prepares the cursor cache for drawing.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc merged commit 436cdf1 into OpenTTD:master Mar 8, 2021
@michicc michicc deleted the pr/fix_8825 branch March 8, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants