Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: a250fad20997
Choose a base ref
...
head repository: NixOS/nix
compare: d3ebc96ca500
Choose a head ref
  • 4 commits
  • 14 files changed
  • 1 contributor

Commits on Mar 8, 2021

  1. Add some logic for signing realisations

    Not exposed anywhere, but built realisations are now signed (and this
    should be forwarded when copy-ing them around)
    thufschmitt committed Mar 8, 2021
    Copy the full SHA
    8996ab2 View commit details
    Browse the repository at this point in the history
  2. pathInfoIsTrusted -> pathInfoIsUntrusted

    I guess the rationale behind the old name wath that
    `pathInfoIsTrusted(info)` returns `true` iff we would need to `blindly`
    trust the path (because it has no valid signature and `requireSigs` is
    set), but I find it to be a really confusing footgun because it's quite
    natural to give it the opposite meaning.
    thufschmitt committed Mar 8, 2021
    Copy the full SHA
    a8ac493 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    83a46da View commit details
    Browse the repository at this point in the history
  4. Properly sign the unresolved drvs

    Don't let them inherit the signature from the parent one (because it
    makes no sense to do so), but re-sign them after they have been built
    thufschmitt committed Mar 8, 2021
    Copy the full SHA
    d3ebc96 View commit details
    Browse the repository at this point in the history