Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8784: using alt+enter didn't update the fullscreen toggle visibly #8820

Merged
merged 1 commit into from Mar 8, 2021
Merged

Fix #8784: using alt+enter didn't update the fullscreen toggle visibly #8820

merged 1 commit into from Mar 8, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Not all flows for changing fullscreen resulted in invalidating the game options window.

Description

Basically, the window was not invalidated, so it was never redrawn.
This made it look like it wasn't working, but it really was.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain
Fix OpenTTD#8784: using alt+enter didn't update the fullscreen toggle…
3f0c7df 
… visibly

Basically, the window was not invalidated, so it was never redrawn.
This made it look like it wasn't working, but it really was.
@TrueBrain TrueBrain added this to the 1.11.0 milestone Mar 8, 2021
@TrueBrain TrueBrain merged commit 04db997 into OpenTTD:master Mar 8, 2021
@TrueBrain TrueBrain deleted the mark-game-options-dirty branch March 8, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @LordAro