Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8808: Crash on switching blitters due to double-mapping the video buffer #8822

Merged
merged 1 commit into from Mar 8, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Mar 8, 2021

Motivation / Problem

Something broke and switching blitters would always map the video buffer, no matter if it was previously mapped or not, leading to a crash later on when trying to double-map the buffer.

Description

Only map the video buffer after switching blitters if it was previously mapped.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc added OS: MacOS This issue is related to a Mac OS problem component: OpenGL labels Mar 8, 2021
@michicc michicc merged commit 25656a1 into OpenTTD:master Mar 8, 2021
@michicc michicc deleted the fix_osx_gl branch March 8, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: OpenGL OS: MacOS This issue is related to a Mac OS problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants